Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for many find and replaces #241

Closed
wants to merge 8 commits into from

Conversation

dev-ardi
Copy link
Contributor

@dev-ardi dev-ardi commented Oct 18, 2023

src/replacer.rs Outdated Show resolved Hide resolved
dev-ardi

This comment was marked as outdated.

@dev-ardi dev-ardi force-pushed the ardi/multiple-replaces branch from cb981f2 to a075207 Compare October 19, 2023 09:43
@dev-ardi dev-ardi force-pushed the ardi/multiple-replaces branch from bd72739 to 4754218 Compare October 20, 2023 01:08
@dev-ardi
Copy link
Contributor Author

dev-ardi commented Oct 20, 2023

Done. Caveats:
2 extra vector allocations at the start (should be completely negligible)

  1. changed public API of Replacer::new()
  2. There's probably a more efficient way of achieving what replace does
  3. No colors when there are several patterns.
  4. The regex flags are applied to all patterns

@dev-ardi dev-ardi marked this pull request as ready for review October 20, 2023 01:37
@CosmicHorrorDev
Copy link
Collaborator

I'll be looking at these after I get this pending release out. Just wanted to give a heads up that I'm not ignoring all of these

@dev-ardi
Copy link
Contributor Author

What's left for the release? The release issue tracker #203 is as complete as it gets.

Can I help with anything?

@dev-ardi
Copy link
Contributor Author

dev-ardi commented Nov 3, 2023

This will be a hacky solution up until the new modular architecture is created and merged. I don't know if it's worth it to release it for 1.1 since the API for it will likely change

@dev-ardi
Copy link
Contributor Author

This doesn't make much sense after #282

@dev-ardi dev-ardi closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants